-
Notifications
You must be signed in to change notification settings - Fork 846
Add OPCache file cache and JIT blacklist functions #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
074ea74 to
17839f1
Compare
Girgias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markup issues
| <para> | ||
| &return.void; | ||
| </para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <para> | |
| &return.void; | |
| </para> | |
| <simpara> | |
| &return.void; | |
| </simpara> |
| <para> | ||
| </para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnaud-lb can you provide a description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <para> | |
| </para> | |
| <para> | |
| The function to blacklist, represented as a first class callable. It is also possible to pass an anonymous function, in which case the anonymous function itself is blacklisted. | |
| </para> |
reference/opcache/functions/opcache-is-script-cached-in-file-cache.xml
Outdated
Show resolved
Hide resolved
reference/opcache/functions/opcache-is-script-cached-in-file-cache.xml
Outdated
Show resolved
Hide resolved
reference/opcache/functions/opcache-is-script-cached-in-file-cache.xml
Outdated
Show resolved
Hide resolved
| <para> | ||
| </para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <para> | |
| </para> | |
| <para> | |
| The function to blacklist, represented as a first class callable. It is also possible to pass an anonymous function, in which case the anonymous function itself is blacklisted. | |
| </para> |
|
Thank you @Girgias for the review. I also changed the |
|
@jordikroon can you please rebase this on the latest master, I created (and ran) some scripts to automatically convert the para tags across the opcache folder and automatically apply this to translations. |
470e481 to
9fe9c50
Compare
9fe9c50 to
5b2625d
Compare
|
The PR has been rebased with the master @Girgias |
Girgias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Adds documentation for two OPCache functions:
The opcache_jit_blacklist function exists since 2024 but has never been documented. Additionally opcache_is_script_cached_in_file_cache is new since PHP 8.5.
References:
#4995
php/php-src#15559
php/php-src#16979
Doc tracker:
#3872
#4886